Skip to content

speculative : fix seg fault in certain cases #12454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

speculative : fix seg fault in certain cases #12454

merged 1 commit into from
Mar 18, 2025

Conversation

ggerganov
Copy link
Member

Fixes a crash when using tree-based speculative decoding with greedy sampling:

make -j llama-speculative && ./bin/llama-speculative -m ../models/qwen2.5-32b-coder-instruct/ggml-model-q4_0.gguf -md ../models/qwen2.5-0.5b-coder-instruct/ggml-model-q4_0.gguf --ctx-size 0 -ub 4096 -b 4096 -ngl 99 -ngld 99 -fa --draft-max 8 --draft-min 0 --draft-p-min 0.75 -c 4096 --color -p "Write a quicksort algorithm" -np 4 --top-k 1 -s 1

@ggerganov ggerganov merged commit c6af216 into master Mar 18, 2025
47 checks passed
@ggerganov ggerganov deleted the gg/speculative-fix branch March 18, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcurtin ericcurtin ericcurtin approved these changes

Assignees
No one assigned
Labels
examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggerganov @ericcurtin